Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper support for config dispatching #13

Open
yanovs opened this issue Nov 23, 2023 · 0 comments
Open

Add proper support for config dispatching #13

yanovs opened this issue Nov 23, 2023 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@yanovs
Copy link
Collaborator

yanovs commented Nov 23, 2023

Here's an interesting pattern that just works right now:

import dilib


class CarConfig(dilib.Config):
    engine_cfg_a = EngineConfigA()
    engine_cfg_b = EngineConfigB()
    engine_cfg = dilib.Forward(engine_cfg_b)

    engine = dilib.Forward(engine_cfg.engine)

We should:

  • Add unit tests for this
  • Document the pattern in the README
  • It actually almost just works: we need to fix perturbing the engine cfg
@yanovs yanovs self-assigned this Nov 23, 2023
@yanovs yanovs added bug Something isn't working documentation Improvements or additions to documentation labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant