Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: bump images version #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luckydonald
Copy link
Contributor

Updated dependency containers (traefik, mariadb, redis):

  • traefik:2.10.4 -> 2.11.0
  • mariadb:10.5 -> 11.3.2
  • redis:4.0-alpine -> 7.2.4-alpine

Tested the traefik configuration with anonaddy:1.0.8.

That's also the reason why I didn't bump nginx, as I didn't test that example.
I only updated the tested images.

@luckydonald
Copy link
Contributor Author

Okey, that failed test build is weird.
It says

Error: buildx bake failed with: 
 ERROR: failed to solve: failed to do request: 
 Head "https://registry-1.docker.io/v2/docker/dockerfile/manifests/1": 
 net/http: TLS handshake timeout

Sounds like a hiccup with some docker api?

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see review about pining versions otherwise LGTM. Please squash your commits when changed on your side and set a commit message like "examples: bump images version" as they are all linked together in versioning anyway. Thanks!

examples/compose/compose.yml Outdated Show resolved Hide resolved
examples/compose/compose.yml Outdated Show resolved Hide resolved
examples/nginx/compose.yml Outdated Show resolved Hide resolved
examples/nginx/compose.yml Outdated Show resolved Hide resolved
examples/rspamd/compose.yml Outdated Show resolved Hide resolved
examples/rspamd/compose.yml Outdated Show resolved Hide resolved
examples/traefik/compose.yml Outdated Show resolved Hide resolved
examples/traefik/compose.yml Outdated Show resolved Hide resolved
examples/traefik/compose.yml Outdated Show resolved Hide resolved
@crazy-max crazy-max changed the title Bump version of the other containers examples: bump images version Feb 28, 2024
- `traefik:2.10.4` -> `2.11.0`
- `mariadb:10.5` -> `11.3.2`
- `redis:4.0-alpine` -> `7.2.4-alpine`

Updated the following examples:
- `examples/compose`
- `examples/nginx`
- `examples/rdspamd`
- `examples/traefik`

Tested the `traefik` configuration with `anonaddy:1.0.8`.

That's also the reason why I didn't bump the `nginx` image as I didn't test that example.
I only updated the tested images.
@luckydonald
Copy link
Contributor Author

luckydonald commented Feb 28, 2024

I was under the impression github would have pr-squasing somewhere in the UI. Oh well.

Anyways, it's squashed now.

Even if commit cecce66 was much cooler sounding than 5874c3c.

Edit: Apparently it does:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

Under "Pull Requests", select Allow squash merging. This allows contributors to merge a pull request by squashing all commits into a single commit. The default commit message presented to contributors when merging is the commit title and message if the pull request contains only 1 commit, or the pull request title and list of commits if the pull request contains 2 or more commits.

@luckydonald
Copy link
Contributor Author

@crazy-max anything missing here for a merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants