Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Nicer make ports #239

Open
sayanarijit opened this issue Sep 28, 2019 · 2 comments
Open

Nicer make ports #239

sayanarijit opened this issue Sep 28, 2019 · 2 comments

Comments

@sayanarijit
Copy link

I would like to contribute to this project. However, while setting up, the make ports command scares me. I don't want to mess with my system IP tables. In dev environment we should be able to use the ports 4000 and 4001 instead of 80 and 443. Also, we shouldn't need any certificate while developing.

This issue to discuss the possible challenges with my proposal.

@sayanarijit
Copy link
Author

Ok, I was able to access it on 4001. I think we should make it the default port for development. Opinions?

@akyoto
Copy link
Member

akyoto commented Sep 30, 2019

The reason we have make ports is because it simplifies a lot of things around local development.

iptables are cleared on reboot. You can also clear them with a script.

You suggest that we shouldn't need a certificate for local development but this suggestion needs to come with specific ideas on how to locally test PWAs and service workers with HTTPS requirements.

If you have any ideas on how these can be tested locally without a certificate installation, please let me know.

P.S. If you don't want to trust the default certificate in the GitHub repository, you can also make your own.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants