Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fxLayoutGap not working with Angular Universal #1298

Open
tommueller opened this issue Sep 29, 2020 · 2 comments
Open

fxLayoutGap not working with Angular Universal #1298

tommueller opened this issue Sep 29, 2020 · 2 comments

Comments

@tommueller
Copy link

tommueller commented Sep 29, 2020

Bug Report

What is the expected behavior?

When using fxLayoutGap, the calculated margins should be added to the DOM also in Angular Universal.

What is the current behavior?

Currently this for example, does not add a margin right to the first child, when rendered from Angular Universal. When JS is finished loading, the margin exists.

What are the steps to reproduce?

<div fxLayout="row" fxLayoutGap="8px">
  <mat-icon fxFlex>link</mat-icon>
  <a href="someUrl">Link</a>
</div>

Which versions of Angular, Material, OS, TypeScript, browsers are affected?


Angular CLI: 10.0.6
Node: 10.19.0
OS: linux x64

Angular: 10.0.9
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1000.6
@angular-devkit/build-angular     0.1000.6
@angular-devkit/build-optimizer   0.1000.6
@angular-devkit/build-webpack     0.1000.6
@angular-devkit/core              10.0.6
@angular-devkit/schematics        10.0.6
@angular/cdk                      10.1.3
@angular/cli                      10.0.6
@angular/flex-layout              10.0.0-beta.32
@angular/google-maps              10.2.0
@angular/material                 10.1.3
@ngtools/webpack                  10.0.6
@nguniversal/builders             10.0.2
@nguniversal/common               10.0.2
@nguniversal/express-engine       10.0.2
@schematics/angular               10.0.6
@schematics/update                0.1000.6
rxjs                              6.5.5
typescript                        3.9.7
webpack                           4.43.0
@CaerusKaru
Copy link
Member

There's a good chance this was fixed by #1378. Can you build your app using the nightly builds and confirm?

@tommueller
Copy link
Author

I won't get to this before next week. Will test then and let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants