Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading forever - wait-panel #17

Open
josercarmo opened this issue Jul 4, 2020 · 1 comment
Open

Loading forever - wait-panel #17

josercarmo opened this issue Jul 4, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@josercarmo
Copy link
Contributor

Há algum problema com o wait-panel, testei várias vezes aqui e tem momentos que ele não fecha.

image

@libertyseifert
Copy link

libertyseifert commented Jul 4, 2020

Em components/Video.tsx (linha 53):

if (props.hasVideo && props.hasEditBase) {
    this.contentReady = true;
}

A props.hasEditBase precisa ser true para o contentReady ser true e ocultar o wait-panel. Porém, as ações CLEAR_VIDEO e RECEIVE_VIDEO (store/Video.ts) somente modificam hasVideo, e mantêm inalterada hasEditBase, o que provoca o bug.

Eu não sei se essa condição da linha 53 precisa do props.hasEditBase. Ainda estou me familiarizando com o código, mas deixo essas informações para quem estiver mais informado e disposto a corrigir o problema.

@nullconst nullconst added the bug Something isn't working label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants