Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with current c-ares #329

Open
waywardmonkeys opened this issue Mar 31, 2024 · 2 comments
Open

Fails to build with current c-ares #329

waywardmonkeys opened this issue Mar 31, 2024 · 2 comments

Comments

@waywardmonkeys
Copy link

when trying to update c-ares in vcpkg from 1.27 to 1.28, building trantor failed due to use of deprecated functions from c-ares 1.28.0.

...vcpkg/buildtrees/trantor/src/v1.5.17-2fee79a355.clean/trantor/net/inner/AresResolver.cc:127:5: error: 'ares_gethostbyname' is deprecated: Use ares_getaddrinfo instead [-Werror,-Wdeprecated-declarations]
    ares_gethostbyname(ctx_,
    ^
.../vcpkg/installed/arm64-osx/include/ares.h:592:14: note: 'ares_gethostbyname' has been explicitly marked deprecated here
CARES_EXTERN CARES_DEPRECATED_FOR(ares_getaddrinfo) void ares_gethostbyname(
             ^
.../vcpkg/installed/arm64-osx/include/ares.h:145:22: note: expanded from macro 'CARES_DEPRECATED_FOR'
      __attribute__((deprecated("Use " #f " instead")))
                     ^
1 error generated.
@ErikTheBerik
Copy link

Is there any solution to this? I updated c-ares via brew (1.28.1) and I cannot compile drogon due to this trantor error regarding the use of a deprecated function.

@marty1885
Copy link
Collaborator

@ErikTheBerik Can you try the latest master? I've merged a patch that fixes it on my local machine. I want to close this issue if it gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants