Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.2 compatible bindshared changed to singleton #28

Open
wants to merge 1 commit into
base: v0.2
Choose a base branch
from
Open

Laravel 5.2 compatible bindshared changed to singleton #28

wants to merge 1 commit into from

Conversation

ujwaldhakal
Copy link

a

@fwartner
Copy link

push

@amostajo
Copy link
Collaborator

Will push this changes tiday

@fwartner
Copy link

Check out my fork https://github.com/fwartner/laravel-shop https://github.com/fwartner/laravel-shop

Am 11.01.2016 um 15:57 schrieb Alejandro Mostajo notifications@github.com:

Will push this changes tiday


Reply to this email directly or view it on GitHub #28 (comment).

@bkuhl
Copy link

bkuhl commented Feb 5, 2016

It'd be great if this was merged in. Though if this fully supports Laravel 5.2 then the README.md should be updated to reflect it's for 5.2.

@ujwaldhakal
Copy link
Author

Leave it admin doesnt want it to be merged 👍

@bkuhl
Copy link

bkuhl commented Feb 6, 2016

@fwartner Your fork doesn't give this repo credit for the original concepts behind the package in that it doesn't indicate it was forked from here.

You've also mentioned it's L5.2 compatible but haven't updated the README.md

@ujwaldhakal
Copy link
Author

still no merge? wew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants