Revert "Revert "fix: use is-url-online to validate the download links""

This reverts commit edc37d2.

package.json

@@ -60,6 +60,7 @@
     "exec-powershell": "workspace:*",
     "execa": "^5.1.1",
     "extension-tools": "workspace:*",
+    "is-url-online": "^1.4.0",
     "mri": "^1.2.0",
     "msvc-dev-cmd": "github:aminya/msvc-dev-cmd#9f672c1",
     "numerous": "1.0.3",

src/llvm/__tests__/llvm.test.ts

@@ -1,6 +1,6 @@
 import { setupLLVM, VERSIONS, getUrl, setupClangTools, getLinuxUrl } from "../llvm"
 import { getSpecificVersionAndUrl } from "../../utils/setup/version"
-import { isValidUrl } from "../../utils/http/validate_url"
+import { isUrlOnline } from "is-url-online"
 import { setupTmpDir, cleanupTmpDir, testBin } from "../../utils/tests/test-helpers"
 import ciDetect from "@npmcli/ci-detect"
 import execa from "execa"
@@ -14,7 +14,7 @@ jest.setTimeout(400000)
 async function testUrl(version: string) {
   const [specificVersion, url] = await getSpecificVersionAndUrl(VERSIONS, process.platform, version, getUrl)
 
-  if (!(await isValidUrl(url))) {
+  if (!(await isUrlOnline(url))) {
     throw new Error(`Failed to install Version: ${version} => ${specificVersion} \n URL: ${url}`)
   }
 }

src/llvm/llvm.ts

@@ -1,7 +1,7 @@
 import * as path from "path"
 import semverLte from "semver/functions/lte"
 import semverMajor from "semver/functions/major"
-import { isValidUrl } from "../utils/http/validate_url"
+import { isUrlOnline } from "is-url-online"
 import { InstallationInfo, PackageInfo, setupBin } from "../utils/setup/setupBin"
 import { extractExe, extractTarByExe } from "../utils/setup/extract"
 import {
@@ -231,7 +231,7 @@ async function getWin32Url(version: string): Promise<string | null> {
   let fallback = false
   if (olderThan9_1) {
     url = getReleaseUrl(version, prefix, suffix)
-    if (!(await isValidUrl(url))) {
+    if (!(await isUrlOnline(url))) {
       fallback = true // fallback to github
     }
   }

src/utils/setup/version.ts

@@ -1,4 +1,4 @@
-import { isValidUrl } from "../http/validate_url"
+import { isUrlOnline } from "is-url-online"
 import semverCompare from "semver/functions/compare"
 import semverCoerce from "semver/functions/coerce"
 import semverValid from "semver/functions/valid"
@@ -42,7 +42,7 @@ export async function getSpecificVersionAndUrl(
   if (platform === "linux" && version.includes("ubuntu")) {
     const url = await getUrl(platform, version)
     // eslint-disable-next-line no-await-in-loop
-    if (url !== null && (await isValidUrl(url))) {
+    if (url !== null && (await isUrlOnline(url))) {
       return [version, url]
     }
   }
@@ -55,7 +55,7 @@ export async function getSpecificVersionAndUrl(
     // eslint-disable-next-line no-await-in-loop
     const url = await getUrl(platform, specificVersion)
     // eslint-disable-next-line no-await-in-loop
-    if (url !== null && (await isValidUrl(url))) {
+    if (url !== null && (await isUrlOnline(url))) {
       return [specificVersion, url]
     }
   }