Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Quotes for Some Minutes #3

Open
ambercaravalho opened this issue Mar 3, 2024 · 0 comments
Open

Missing Quotes for Some Minutes #3

ambercaravalho opened this issue Mar 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@ambercaravalho
Copy link
Owner

ambercaravalho commented Mar 3, 2024

Description

There are missing quotes for certain minutes throughout the day. This results in some time slots not displaying any quotes directly related to the current time, which detracts from the user experience.

Current Workaround: Nearest Neighbor Algorithm

To address this issue temporarily, there's a nearest neighbor algorithm implemented. When the application cannot find a quote for the exact current minute, it searches for the closest available quote. This approach ensures that a quote is always displayed, but it might not always match the specific minute, affecting the relevance and impact of the quote displayed.


Adding New Quotes

To enhance the application and minimize the reliance on the nearest neighbor algorithm, we're inviting contributions of new quotes. By expanding the quote database, we can ensure a more relevant and engaging user experience, with quotes that more accurately match each minute of the day.

Quote Formatting

Each quote should be formatted as follows:

time|timestring|quote|title|author

  • time: The specific time the quote represents, in 24-hour format (e.g., 14:45).
  • timestring: The way the time is mentioned within the quote, to be highlighted (e.g., quarter to three).
  • quote: The full sentence from the book where the time is mentioned.
  • title: The title of the book the quote is from.
  • author: The author of the book.

For example: 00:00|midnight|It starts at midnight.|Catching Fire|Suzanne Collins

Where to Add The Quotes

Navigate to the script.js file in the project, and you'll find an string named csvData. Add your formatted quote to this array, following the existing structure.

@ambercaravalho ambercaravalho added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Mar 3, 2024
@ambercaravalho ambercaravalho self-assigned this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant