Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyWSD with wn #70

Open
arademaker opened this issue Oct 7, 2021 · 1 comment
Open

PyWSD with wn #70

arademaker opened this issue Oct 7, 2021 · 1 comment

Comments

@arademaker
Copy link

Hi @goodmami and @alvations , is pywsd ready to be used with https://github.com/goodmami/wn? If so, how can we do that? I am trying to write a tutorial for the users of our Portuguese Wordnet at http://github.com/own-pt/openWordnet-PT.

@goodmami
Copy link
Contributor

goodmami commented Oct 7, 2021

I think https://github.com/goodmami/wn can do everything PyWSD needs, but it's just the effort of porting it over. There's not too many places the old wn or wnic are called, and where they are it looks mostly trivial to port:

pywsd$ git grep -cP '\bwn(ic)?\.'
CHANGELOG.md:1
Precompute Signatures.ipynb:1
README.md:2
pywsd/__init__.py:1
pywsd/allwords_wsd.py:1
pywsd/baseline.py:9
pywsd/lesk.py:13
pywsd/similarity.py:17
pywsd/utils.py:7
quick_reference.md:4

One big problem is that this package has few tests and those that exist appear to be broken (e.g., importing pywsd.semcor which was removed a long time ago), so I can't be sure of the correctness. In addition, I wouldn't switch until the next release of https://github.com/bond-lab/omw-data/ which should have an English wordnet that's more compatible with the Princeton WordNet 3.0 and 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants