Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pydantic-settings for app settings object #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use pydantic-settings for app settings object #217

wants to merge 1 commit into from

Conversation

andyhd
Copy link
Contributor

@andyhd andyhd commented Dec 13, 2023

  • Already using pydantic via FastAPI
  • Less to maintain
  • Typed settings - catches config errors

@andyhd andyhd added the norelease Don't bump version number or create a release label Dec 13, 2023
@andyhd andyhd force-pushed the andyhd/chore/refactor-config-to-pydantic-settings branch 2 times, most recently from 2089f39 to 93f6cc2 Compare December 13, 2023 14:27
guilhem-fry
guilhem-fry previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@guilhem-fry guilhem-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@andyhd andyhd force-pushed the andyhd/chore/refactor-config-to-pydantic-settings branch from 93f6cc2 to 3d8dd31 Compare December 13, 2023 16:36
@andyhd
Use pydantic-settings for app settings object
b675eab 
* Already using pydantic via FastAPI
* Less to maintain
* Typed settings - catches config errors
@andyhd andyhd force-pushed the andyhd/chore/refactor-config-to-pydantic-settings branch from 3d8dd31 to b675eab Compare December 13, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-fry guilhem-fry guilhem-fry left review comments

@nacnudus nacnudus Awaiting requested review from nacnudus

Assignees
No one assigned
Labels
norelease Don't bump version number or create a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyhd @guilhem-fry