Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Nx.dev compatibility #32

Open
binary64 opened this issue Feb 28, 2022 · 6 comments
Open

Feature request: Nx.dev compatibility #32

binary64 opened this issue Feb 28, 2022 · 6 comments

Comments

@binary64
Copy link

Hi I love the idea of your plugin. I'm trying to get it to work in my monorepo, which uses Nx.dev.

Here's how you can get a repo locally to test with:

npm i -g yarn && \
rm -rf ~/nx-demo && \
cd ~/ && \
npx create-nx-workspace nx-demo --packageManager=yarn --style=less --nx-cloud=false --interactive=false --preset=empty --linter=eslint && \
cd nx-demo

I currently get this error

Error: Command failed with exit code 1: tsc --showConfig
error TS5081: Cannot find a tsconfig.json file at the current directory: C:/p/nx_test.

Many thanks!

@kamkry
Copy link
Collaborator

kamkry commented Mar 1, 2022

Hi, you can quickly fix it either by renaming tsconfig.base.json to tsconfig.json, or by adding new tsconfig.json with following body:

{
  "extends": "./tsconfig.base.json",
}

@binary64
Copy link
Author

binary64 commented Mar 2, 2022

I tried both of your suggests, but I run node_modules/.bin/update-strict-comments I get:

Project does not contain any strict files.

Any ideas? It's a pretty plain Nx repo

@kamkry
Copy link
Collaborator

kamkry commented Mar 2, 2022

Does your project include any typescript files? That error is thrown only when either there's no TS files or every TS file is ignored with //@ts-strict-ignore comment

@binary64
Copy link
Author

binary64 commented Mar 4, 2022

Yes, I only have mostly .tsx and .ts files. And a couple of .js files.

I don't have any @ts-strict-ignore's

@anatter
Copy link

anatter commented Jan 2, 2023

@binary64 I currently have the same issue, have you found a solution yet?

@TheBox193
Copy link

Same here. Looks like this plugin lacks support for entry points for projects with multiple tsconfig files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants