-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate testcontainers into the current test environment #2524
Open
kaori-seasons
wants to merge
26
commits into
alibaba:2021.x
Choose a base branch
from
kaori-seasons:integration-test
base: 2021.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
related to integrated test environment
improve pospal
It is necessary to design a set of integration testing solutions for the project, which can better test whether the functions of components such as Nacos, RocketMQ, Seata, Sentinel in the project serve expectations, improve the efficiency of project integration testing, and realize intelligent automatic testing through Github CI
Code branch: integration-test
Project background: Previously in the spring-cloud-alibaba-tests/nacos-old-tests module, based on the
@HasDockerAndItEnabled
annotationExecute mvn clean -Dit.enabled=true test in the ci script to execute all unit tests marked with this annotation
Currently we need to plug in our new version of unit tests for nacos and rocketmq whenever a new module needs to be plugged in
Specify the module in spring-cloud-alibaba-tests/spring-cloud-alibaba-testcontainers/pom.xml
The following work needs to be done
In the new module spring-cloud-alibaba-tests/intergration/nacos-docker-tests
To do some nacos coverage tests, you can refer to the unit tests of each module of nacos
File path: https://github.com/alibaba/nacos/tree/develop/test
Improve the test coverage of the nacos module
In the new module spring-cloud-alibaba-tests/intergration/rocketmq-docker-tests
Do some coverage tests of rocketmq, you can refer to rocketmq
File path: https://github.com/apache/rocketmq/tree/develop/test/src/test
For the actual use of the user, the mixed use of nacos + rocketmq may occur.
Currently some actions can be predefined in the xxxxTester class
Path: spring-cloud-alibaba-tests/spring-cloud-alibaba-testcontainers/src/main/java/com/alibaba/cloud/integration/common
You can try to start by combining containers to improve coverage
It is expected to do e2e end-to-end testing similar to the following KafkaDebeziumSourceTests
File path: apache/flink@master...complone:flink-hackthon-2021-issue-6
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews