Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess code.(related issue #12871 ) #12874

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

littlesparklet
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

To remove excess code in zh-CN.js and en-US.js.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (a24e7ac) to head (ec4318b).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12874      +/-   ##
=============================================
+ Coverage      72.16%   72.26%   +0.09%     
- Complexity      9793     9825      +32     
=============================================
  Files           1283     1287       +4     
  Lines          41387    41445      +58     
  Branches        4374     4373       -1     
=============================================
+ Hits           29868    29950      +82     
+ Misses          9413     9391      -22     
+ Partials        2106     2104       -2     

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24e7ac...ec4318b. Read the comment docs.

---- 🚨 Try these New Features:

@KomachiSion KomachiSion added the area/Nacos console Related to Nacos consle label Nov 21, 2024
@KomachiSion KomachiSion linked an issue Nov 21, 2024 that may be closed by this pull request
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Nov 21, 2024
@KomachiSion KomachiSion added this to the 2.5.0 milestone Nov 21, 2024
@KomachiSion KomachiSion merged commit 93ea0dd into alibaba:develop Nov 21, 2024
8 checks passed
@wuyfee
Copy link

wuyfee commented Nov 21, 2024

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
❌ - e2e-cpp-test (standalone & cluster): failure
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is duplicate code in the zh-CN.js and en-US.js files
4 participants