Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method dateCorrection is not working #36

Open
alhoqbani opened this issue Jul 30, 2017 · 0 comments
Open

Method dateCorrection is not working #36

alhoqbani opened this issue Jul 30, 2017 · 0 comments

Comments

@alhoqbani
Copy link
Owner

The method dateCorrection is supposed to calculate the correction factor for the Hijri date conversion based on Um Alqura calendar. It supports date range 1420-1459, and should return a correction factor range from -2 to +2.

However, the method is not working and almost always returns 0.

I have tested every month from the supported range (1420-1459). Out of 456 tested months, only 21 months returned a value different than 0, which does not seem right.

This commit a121197 adds a test to check the functionality of the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant