-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: visual design #1
Comments
Here's a thought: what if each thread name/identifier in the columns (i.e. what shows after |
Should I reverse the indentation when using from snoop import pp
x = 1
y = 2
z = 3
assert 6 == pp.deep(lambda: x + y + z) Currently outputs this:
Would it be better if I changed it to this?
Thumbs up to change it, thumbs down to keep it the same. |
Hi @alexmojaki! In order to reply to your question about if you have to reverse the indentation of
|
Would it make sense to change the indent char from |
@martinsmid can you elaborate? |
Maybe something like this
I didn't think about this thoroughly yet. And also I am not experienced with the current snoop's output in general. Now when I look at the original output in your post, I would probably just differentiate the indent as in my example, without the reversal of the indent.
|
Why do you want to differentiate between the dots? Does anyone else think this would be helpful? |
Nope |
For multi-line output, could the Example: from pathlib import Path
import snoop
snooper = snoop.Config(columns='time,thread,thread_ident,file,full_file,function,function_qualname', out='tmp.log')
snooper.pp([*Path(__file__).parent.resolve().glob('*.*')]) Currently it might look like this:
But i would find it easier to read like this
Or maybe there is a happy medium:
|
@KyleKing I don't like this idea. Having a consistent block of columns is:
|
Okay makes sense On another note, could a column option be available for the from pathlib import Path
import snoop
snooper = snoop.Config(columns='time,file,line')
snooper.pp([*Path(__file__).parent.resolve().glob('*.*')])
(I'm not sure how the first LOG line would be handled, but put |
You can do this: from pathlib import Path
import snoop
def line_column(event):
return event.line_no
snooper = snoop.Config(columns=['time', 'file', line_column])
snooper.pp([*Path(__file__).parent.resolve().glob('*.*')]) It feels a bit weird to add this as a column since the line number is usually showing if you use |
For this program: from snoop import pp
x = 1
y = 2
z = 3
assert 6 == pp.deep(lambda: x + y + z) Why not output this? 12:21:10.98 LOG:
12:21:11.01 .... x = 1
12:21:11.01 ........ y = 2
12:21:11.01 .... x + y = 3
12:21:11.01 ............ z = 3
12:21:11.01 .... x + y + z = 6 |
The current look of snoop is the result of many small decisions and I really don't know if I made the right ones. What would you change about the appearance if you could? This could be about color, layout, the choice of words or special characters, and more. No detail is too small to post about here. Please also vote on proposals with reactions to help me see how popular they are.
The text was updated successfully, but these errors were encountered: