Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework derivative discretizations #57

Merged
merged 26 commits into from
Aug 12, 2024
Merged

Rework derivative discretizations #57

merged 26 commits into from
Aug 12, 2024

Conversation

alexfikl
Copy link
Owner

@alexfikl alexfikl commented Jul 14, 2024

See discussion in #55. Methods that need updating

Caputo

  • L1
  • ModifiedL1
  • L2
  • L2C
  • SpectralJacobi
    • This method evaluates the derivative on the whole grid.
  • YuanAgrawal
  • Diethelm
  • BirkSong

Riemann-Liouville

Should just work once Caputo methods are updated.

Grünwald-Letnikov

  • GrunwaldLetnikov
  • ShiftedGrunwaldLetnikov
  • TianZhouDeng2
  • TianZhouDeng3

Gradient

Reimplement gradient based on diffs method. Methods that don't support it can take a long hard look at themselves.

Fixes #55.

@alexfikl alexfikl marked this pull request as ready for review August 12, 2024 18:06
@alexfikl
Copy link
Owner Author

This turned out to be a bit of a pain. Had to re-derive most of the methods to be able to write out the weights and diffs separately.

For now, the interface seems nice enough and the most used methods are ported. The rest of them can be done one by one whenever someone finds the time and the will 😁

@alexfikl alexfikl merged commit 5dbb796 into main Aug 12, 2024
13 checks passed
@alexfikl alexfikl deleted the rework-diff branch August 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[diff] Rework evaluation in diff
1 participant