Fix SWR Cache Quota #223
Fix SWR Cache Quota #223
Conversation
| @@ -129,3 +132,25 @@ function buildGetTransactionsFn(metadataTransactions: Transaction[]) { | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| export async function pruneTransactionsInfiniteScrollCache() { | |||
There was a problem hiding this comment.
Does this function try to clear the cache of unselected accounts?
There was a problem hiding this comment.
Yes, if we have a selected account (we normally have unless this is a new wallet), then it will clear the cache for infinite scroll transaction for all other unselected accounts.
There was a problem hiding this comment.
If I switch accounts twice, does it mean all account cache for scrolling would be removed?
There was a problem hiding this comment.
If we switch account and close & open the extension wallet, it will clear all the account cache for transactions infinite scroll. Only switching account won't clear all scrolling cache.
The consequence of not having the infinite scroll cache is that if we click the activity tab to look at transaction history, it will try to fetch from the explorer backend immediately
Do you think this is too aggressive?
There was a problem hiding this comment.
Does SWR support LRU cache with a limited capacity? LRU cache can handle clearing automatically.
There was a problem hiding this comment.
SWR doesn't seem to have built-in support for LRU cache with limited capacity. I can investigate if we can integrate with custom cache provider to achieve this.
SWR Cache uses the
localStorageas backend, which has a 10MB limit. The one uses the most space is the infinite scroll cache for transactions (~75% for my wallet)This PR:
useArrayStorage, only cache the selected results instead of all results