Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Implement tests #92

Open
3 of 25 tasks
nop33 opened this issue Dec 22, 2021 · 4 comments
Open
3 of 25 tasks

Implement tests #92

nop33 opened this issue Dec 22, 2021 · 4 comments
Labels
feature New feature investigation Research and design task

Comments

@nop33
Copy link
Member

nop33 commented Dec 22, 2021

src/pages/Wallet/WalletHomePage.tsx

  • Correctly fetches and displays latest balance and number of transactions on initial load
  • Correctly fetches and displays latest transactions on initial load
  • Snackbar is displayed when there is an error fetching initial data
  • Correctly updates balance and number of transactions when refresh button is pressed
  • Correctly fetches and displays latest transactions when refresh button is pressed
  • Snackbar is displayed when there is an error refreshing data
  • If there are pending transactions, ensure that it keeps fetching data every 2 seconds until no more pending transactions exist
  • The settings modal opens when clicking the settings button
  • The spinner is displayed while refreshing data
  • Clicking the "Show address" action button opens the correct modal
  • Clicking the "Send token" action button opens the correct modal
  • Clicking the "Lock account" action button locks the wallet
  • Correct footer message is displayed based on the number of transactions
  • "Load more" button fetches and displays the next page of transactions

Creating transaction

  • Displays a pending transaction in the list of transactions when a new one is created
  • Displays an error message if the address validation failed
  • Disables the submit button if there is no address
  • Disables the submit button if there is no amount
  • Disables the submit button if there is an error
  • Converts the amount into a qALPH string

Switching network settings

  • Transaction list gets updated when switching networks
  • Balance gets updated when switching networks
  • Number of transactions is updated when switching networks

Address page

  • Button to copy the address correctly copies the address and displays a success message
  • Clicking "Show in explorer" opens the correct link in the browser
@nop33 nop33 changed the title WIP: Implement tests Implement tests Dec 23, 2021
@lf94 lf94 added feature New feature investigation Research and design task labels May 5, 2022
@lf94
Copy link
Contributor

lf94 commented May 6, 2022

Discussion should exist to determine:

  • Reason UI tests should exist
  • Do we have the resources to maintain the tests
  • What testing framework do we want to use

My experience with UI tests is they always become stale and extremely difficult to maintain with one person.

Doing our current manual testing methodology seems to be pretty effective, time efficient, and comprehensive.

@nop33
Copy link
Member Author

nop33 commented May 9, 2022

I agree writing/maintaining UI tests is a pain in the 🍑

Doing our current manual testing methodology seems to be pretty effective, time efficient, and comprehensive

I would argue that it is very time consuming (I was testing for days before the last release, time which could have been invested in other things).

Every time we find a bug and we fix it, we need to test everything again, cause we might have introduced another bug (it happened in the last release that a fix introduced another bug).

Maybe just bringing in the community to help us test would be a way to ease the pain.

@lf94
Copy link
Contributor

lf94 commented May 9, 2022

It's time consuming, but at least the time is being used in a effective manner, rather than fighting a test framework and reworking many tests, and UI tests can throw false positives.

I agree bringing in the community would be even better, and usually more representative of how the wallet will be used by average people.

@nop33
Copy link
Member Author

nop33 commented Nov 16, 2023

@mvaivre shall we close this issue, or transfer it to the monorepo, what do you think? Most of the subtasks mentioned here are not relevant anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature investigation Research and design task
Projects
None yet
Development

No branches or pull requests

2 participants