test: Add Tests and Improve Test Coverage for packages/web3/src/contract #469
+1,035
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @polarker this test really stressed me out |
h0ngcha0
reviewed
Nov 27, 2024
| @@ -1,24 +1,8 @@ | |||
| /* | |||
There was a problem hiding this comment.
Q: Why do we need to change this file?
There was a problem hiding this comment.
Unresolve this issue since it is not resolved.
There was a problem hiding this comment.
It doesn't test that's why 😔
|
Hey, I can not build and run tests with the branch, could you please make sure that it builds and all tests are executed correctly? pnpm install
npm run build
npm run test |
|
You have to cd into packages/web3 then build |
It should be able to build at the top directory, that is how CI runs the pipeline as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add test for non tested files and improved test converage #453