Replace special characters with hyphen in featureName #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for future Maven updates that may not support certain characters,
this commit updates the featureVersion method to replace especial
characters, including '/', ':', '"', '<', '>', '|', '?', '*', and '\', with a
hyphen ('-') in the featureName parameter. Additionally, it ensures that multiple
hyphens are not consecutively present in the result.
|
@ccerrillo Why this is needed? Validation seems like better place for that. And there is |
|
Some Git clients allow these types of branch names and can then display them in a tree-like structure. Personally, I find this very useful. The problem arose because if I did it this way, the name was transferred directly to the POM. My goal is not to restrict it but to allow it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for future Maven updates that may not support certain characters, this commit updates the featureVersion method to replace especial characters, including '/', ':', '"', '<', '>', '|', '?', '*', and '', with a hyphen ('-') in the featureName parameter. Additionally, it ensures that multiple hyphens are not consecutively present in the result.
This allows branch names like "feature/2023-09-28/my-awesome-feature"