Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-start fails with -DskipUpdateVersion=true #408

Open
pgarcia-sonoc opened this issue Aug 6, 2024 · 2 comments
Open

release-start fails with -DskipUpdateVersion=true #408

pgarcia-sonoc opened this issue Aug 6, 2024 · 2 comments

Comments

@pgarcia-sonoc
Copy link

pgarcia-sonoc commented Aug 6, 2024

When the version update is skipped it doesn't change the poms but still issues a commit after. This commit fails because there are no changes.
[ERROR] Failed to execute goal com.amashchenko.maven.plugin:gitflow-maven-plugin:1.21.0:release-start (default-cli) on project xxx-parent: Failed cmd ['git'] with args [[commit, -a, -m, [RELEASE]Update versions for release]], bad exit code [1]. Out: [ [ERROR] On branch release/1.10 [ERROR] nothing to commit, working tree clean [ERROR] ]

The final result is correct. That is the release branch is created, the version is not changed and there are no commits. But the error in the console looks ugly and it stops the process to continue with other goals

@kirbylink
Copy link

kirbylink commented Sep 11, 2024

I can confirm that problem. It's not only "ugly". It also stops CI Pipelines to work since it exits not with Code 0

Edit: In addition, it might not be a bad idea to be able to choose the branch name. If you don't want to update the version, then hotfix/x.y.z name for the branch makes little sense

@pgarcia-sonoc
Copy link
Author

I wonder if there is any conflict with useSnapshotInRelease, because that's the behavior I'm trying to replicate. I just didn't know that parameter. I will try to use it and see if it works. I hope it doesn't try to commit if the snapshot version is the same already set in the code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants