Not sure how to pygubu please with inheritence and spawning new windows

[coffeelover1010]

Hi, can anyone tell me under the hood why code1 spawns new windows for me and code 2 doesn't?

code1

class PyGubuBuilder:
    def __init__(self, ui_filename):
        self.builder = pygubu.Builder()
        self.builder.add_resource_path(PROJECT_PATH)
        self.builder.add_from_file(PROJECT_PATH / ui_filename)
        self.toplevel1 = self.builder.get_object('toplevel1')
        self.builder.connect_callbacks(self)

class MyUI(PyGubuBuilder):
    def __init__(self):
        super().__init__('pygubu2.ui')
        
class App(PyGubuBuilder):
    def __init__(self):
        super().__init__('pygubu.ui')
        self.mainwindow = self.builder.get_object('toplevel1')
        
        self.myui = []
        
    def command_new_ui(self):
        self.myui.append(MyUI())

code2

class PyGubuBuilder:
    def __init__(self, ui_filename):
        self.builder = pygubu.Builder()
        self.builder.add_resource_path(PROJECT_PATH)
        self.builder.add_from_file(PROJECT_PATH / ui_filename)
        self.builder.connect_callbacks(self)

class MyUI(PyGubuBuilder):
    def __init__(self):
        super().__init__('pygubu2.ui')
        self.toplevel1 = self.builder.get_object('toplevel1')
        
class App(PyGubuBuilder):
    def __init__(self):
        super().__init__('pygubu.ui')
        self.mainwindow = self.builder.get_object('toplevel1')
        
        self.myui = []
        
    def command_new_ui(self):
        self.myui.append(MyUI())

[alejandroautalan]

Hello @coffeelover1010 thanks for trying pygubu.

This is my answer:

Code1

class PyGubuBuilder:
    def __init__(self, ui_filename):
        self.builder = pygubu.Builder()
        self.builder.add_resource_path(PROJECT_PATH)
        self.builder.add_from_file(PROJECT_PATH / ui_filename)
        self.toplevel1 = self.builder.get_object('toplevel1')  # <- Creating the toplevel 
        self.builder.connect_callbacks(self)                   # <- Connecting callbacks after all
                                                               #    widgets created. OK
                                                               # the button is connected and works

Code2

class PyGubuBuilder:
    def __init__(self, ui_filename):
        self.builder = pygubu.Builder()
        self.builder.add_resource_path(PROJECT_PATH)
        self.builder.add_from_file(PROJECT_PATH / ui_filename)
        self.builder.connect_callbacks(self)    # <- Calling connect here does nothing because
                                                # No widget was created yet.
                                                # the button is created later.

Solution for code 2

class PyGubuBuilder:
    def __init__(self, ui_filename):
        self.builder = pygubu.Builder()
        self.builder.add_resource_path(PROJECT_PATH)
        self.builder.add_from_file(PROJECT_PATH / ui_filename)
        self.builder.connect_callbacks(self)

class MyUI(PyGubuBuilder):
    def __init__(self):
        super().__init__('pygubu2.ui')
        self.toplevel1 = self.builder.get_object('toplevel1')
        self.builder.connect_callbacks(self)  # <- Connect callbacks

class App(PyGubuBuilder):
    def __init__(self):
        super().__init__('pygubu.ui')
        self.mainwindow = self.builder.get_object('toplevel1')
        self.builder.connect_callbacks(self)  # <- Connect callbacks

        self.myui = []

    def command_new_ui(self):
        self.myui.append(MyUI())

Remember that connect_callbacks should be called after all related widgets have been created.

Regards
Alejandro A.

[coffeelover1010]

Hi Alejandro,

Thank you for the response, I found it very helpful.

I ended up passing the subclass, main widget and tk vars to the base class, this makes code for creating new builders/windows as the user requests easier and more readable for me thank you.

I am also finding it easy to add in new windows made with pygubu-designer, I just add a new class along with the ui file and add in the subclass specific stuffs and all the pygubu side is all fairly generic and organized neatly in its own place so I can focus on the functionality specific things.

In the end, the pygubu builder and designer are a great combo for me, I like them very much.

[alejandroautalan]

Hello @coffeelover1010, I'm very glad that pygubu is useful to you.

I don't know if you saw this comment, but one of the next versions will directly generate both classes.
I think this will speed up the development process much more.

Greetings.
Alexander A.

[coffeelover1010]

I didn't see that example before, it's cleaner than my current code

I think if I pass in the master to my other UI files I can use that approach and use code generation, something to consider next time

p.s. the copy paste using xml was very helpful thank you! i had many pygubu-designer windows open, it was very nice!