Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation sets in RSR #228

Open
nadiagorchakova opened this issue Nov 24, 2016 · 1 comment
Open

Validation sets in RSR #228

nadiagorchakova opened this issue Nov 24, 2016 · 1 comment
Labels

Comments

@nadiagorchakova
Copy link

nadiagorchakova commented Nov 24, 2016

Right now we have a 'super' validation set 'RSR' which applies by default to all projects in RSR. This is a collection of mandatory fields and hidden fields. The fields that are not flagged up there are 'nice to have'.

In addition to that, there is a possibility to create a custom validation set based on organisation's needs, for example NLR validation set. In a custom validation set, you can only hide fields which are already hidden and are not mandatory in 'RSR' validation set. It makes a lot of sense to cross-check for mandatory fields and not allow hiding them in any custom validation set. However, when it comes to hiding fields which are not mandatory (but also not hidden) in RSR validation set, the logic gets a bit vague.

We should think about the best way to allow partners hide fields, which are not flagged as mandatory in RSR validation set. Some partners complain that we promise them a possibility of having their own validation set, but at the same time do not allow to hide fields which are not even mandatory.

@punchagan, we already talked at length about it and you said you'd give it more thought. Please comment, if you have some further thoughts on that.

Related to this incident: #213

@punchagan
Copy link

  • Mandatory field: A field becomes mandatory if even one of the validation set marks it as mandatory
  • Hidden field: A field gets hidden in the project editor only if all the validation sets mark it as hidden.

We don't wish to change the RSR validation set, because every project uses it. Making a field hidden, for example, would hide it for all the projects that only use the RSR validation set (a lot of projects!). Even then, how was it decided (and in future how do we decide) that a field should be hidden/mandatory in RSR or not?

The logic for the hidden field could be changed to be similar to the mandatory field logic, i.e., a field becomes hidden if it is marked as hidden in even one of the validation sets. But, this would mean the current custom validation sets would need to be modified to be able to explicitly state that a field should be shown (3rd option, along with hidden and mandatory). This would make the logic very simple and explicit, but would need some work modifying the existing validation sets.

We could also considering a third option -- "super" hide -- alongside the existing hidden and mandatory options. The logic for the hidden option would remain the same -- a field is hidden if it is marked as hidden in all validations. But, additionally, it is also hidden if any of the validation set "super" hides it, irrespective of whether or not other validation sets hide it. "Super"-hide would not be able to hide a field marked as mandatory by another validation set.

@punchagan punchagan removed their assignment Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants