Merge pull request #1367 from akto-api-security/hotfix/api_groups_count

use host header filter for counting apis in api groups
akto-api-security · Aug 19, 2024 · 1414e1f · 1414e1f
2 parents 105cdd2 + 2cbe5fc
commit 1414e1f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/apps/dashboard/src/main/java/com/akto/action/ApiCollectionsAction.java b/apps/dashboard/src/main/java/com/akto/action/ApiCollectionsAction.java
@@ -92,7 +92,11 @@ public List<ApiCollection> fillApiCollectionsUrlCount(List<ApiCollection> apiCol
                 apiCollection.setUrlsCount(count);
             } else if(ApiCollection.Type.API_GROUP.equals(apiCollection.getType())){
                 if (count == null) {
-                    count = SingleTypeInfoDao.instance.countEndpoints(Filters.in(SingleTypeInfo._COLLECTION_IDS, apiCollectionId));
+                    List<Bson> filters = SingleTypeInfoDao.filterForHostHostHeaderRaw();
+                    filters.add(Filters.in(SingleTypeInfo._COLLECTION_IDS, apiCollectionId));
+                    count = (int) SingleTypeInfoDao.instance.count(
+                            Filters.and(filters)
+                    );
                 }
                 apiCollection.setUrlsCount(count);
             } else {

diff --git a/libs/dao/src/main/java/com/akto/dao/SingleTypeInfoDao.java b/libs/dao/src/main/java/com/akto/dao/SingleTypeInfoDao.java
@@ -90,13 +90,18 @@ public static Bson filterForSTIUsingURL(int apiCollectionId, String url, URLMeth
         );
     }
 
-    public static Bson filterForHostHeader(int apiCollectionId, boolean useApiCollectionId) {
+    public static List<Bson> filterForHostHostHeaderRaw() {
         List<Bson> filters = new ArrayList<>();
         filters.add(Filters.eq(SingleTypeInfo._RESPONSE_CODE, -1));
         filters.add(Filters.eq(SingleTypeInfo._IS_HEADER, true));
         filters.add(Filters.eq(SingleTypeInfo._PARAM, "host"));
         filters.add(Filters.eq(SingleTypeInfo.SUB_TYPE, SingleTypeInfo.GENERIC.getName()));
 
+        return filters;
+    }
+
+    public static Bson filterForHostHeader(int apiCollectionId, boolean useApiCollectionId) {
+        List<Bson> filters = filterForHostHostHeaderRaw();
         if (useApiCollectionId) filters.add(Filters.eq(SingleTypeInfo._API_COLLECTION_ID, apiCollectionId));
 
         return Filters.and(filters);