Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is flat_packages enabled by default? #1956

Open
jroper opened this issue Jun 18, 2024 · 1 comment
Open

Why is flat_packages enabled by default? #1956

jroper opened this issue Jun 18, 2024 · 1 comment

Comments

@jroper
Copy link
Contributor

jroper commented Jun 18, 2024

In my experience working with akka-grpc, flat_packages is almost never wanted, because there are a number of protobuf descriptors out there that are shared between many grpc interfaces, and Java versions of these very often end up on the classpath. I think scalapb made the right decision by having this feature and making the non flattened packages the default, as it avoids these issues, that often only appear at runtime. So, the question is, why does akka-grpc take the opposite approach?

@johanandren
Copy link
Member

I don't remember at all, and the PR where we originally set it doesn't make it much clearer: #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants