-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of the "_defaultMessage" overrides messages defined in schema #232
Comments
So any solution on this so far? Why should this thing replace custom messages with translated default ones? =/ |
I avoid this with the following workaround by filtering errors for specific keywords (e.g. "errorMessage") and only localize the others. For example:
|
it work, thanks this reply. |
Hi!
Thanks for this great library!
I am in the process of upgrading to v8 as well as errors, i18n and formats plugins. I am noticing that one thing that works differently is the uses of default messages in i18n.
The console outputs lots of "must pass "errorMessage" keyword validation", even though I have defined "errorMessage" in the schema. It used to work in v7 with plugins.
https://github.com/ajv-validator/ajv-i18n/blob/master/messages/index.js#L80 generate a default case to the switch statements that override every single message.
The code definitely works, it is not a bug. However, the behaviour is totally different from the previous version, and wondering if it is the desired behaviour. If it is, wondering how to provide error messages from schema (using "errorMessage") as well as from the i18n plugin. Messages within "errorMessage" in my schema are translated.
EDIT
I am noticing that #220 is probably a similar issue.
The text was updated successfully, but these errors were encountered: