Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1874 support workers for ASGI FastStream #1936

Merged
merged 5 commits into from
Nov 29, 2024
Merged

fix: #1874 support workers for ASGI FastStream #1936

merged 5 commits into from
Nov 29, 2024

Conversation

Sehat1137
Copy link
Contributor

@Sehat1137 Sehat1137 commented Nov 24, 2024 •
edited
Loading

Description

  • Add support workers via gunicorn

  • Add support fd & unix socket

  • Add new external params --bind

  • Separate --bind params from app

Fixed this issues: #1874 #1946

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

fix: airtai#1874 support workers for ASGI FastStream
80e7412 
- Add support workers via gunicorn

- Add support fd & unix socket

- Add new external params `--bind`

- Separate `--bind` params from app
@Lancetnik Lancetnik added the bug Something isn't working label Nov 29, 2024
@Lancetnik Lancetnik added this pull request to the merge queue Nov 29, 2024
Merged via the queue into airtai:main with commit 90aaf57 Nov 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lancetnik Lancetnik Lancetnik approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sehat1137 @Lancetnik