Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event propagation issues due to signClient lifecycle #829

Open
IsaccoSordo opened this issue Nov 5, 2024 · 0 comments
Open

Event propagation issues due to signClient lifecycle #829

IsaccoSordo opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@IsaccoSordo
Copy link
Collaborator

Describe the Bug (Current Behavior)
It appears that closeSignClient in WalletConnectCommunicationClient is causing issues with session event propagation.

Steps to Reproduce

  1. After pairing with a wallet, click "Disconnect."
  2. Pair with the wallet again.
  3. From the wallet, send a session update.
  4. The dApp does not receive the event.

Expected (Correct) Behavior
Contrary to Beacon’s original design, a signClient reference should always maintain an open connection to the relayer.

Environment

  • Device: Macbook Pro M1 Max
  • OS: macOS Sequoia 15.0.1
  • Browser Chrome
@IsaccoSordo IsaccoSordo added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IsaccoSordo