Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #327

Closed
wants to merge 1 commit into from
Closed

Conversation

ianmacartney
Copy link

Without this, the OPTIONS request fails when there are multiple resources per route.

What do these changes do?

Updates the README for the example for allowing CORS on all routes by default.

Are there changes in behavior for the user?

Only README changes, no changes to behavior.

Related issue number

This was suggested in #226 as a workaround.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist -> N/A
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Without this, the `OPTIONS` request fails when there are multiple resources per route. This was suggested in aio-libs#226 as a workaround.
@ianmacartney
Copy link
Author

Didn't get any feedback on this, going to close out as it's very stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant