[#473] Fix connection status output #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pgagroal-cli` was reporting the wrong status for connections because it was decoding the connection status via `pgagroal_server_state_as_string` that is used to decode the status of a server. This commit renames the already existent function `pgagroal_get_state_string` as `pgagroal_connection_state_as_string` for consistency with the server one (`pgagroal_server_state_as_string``) and makes the management decoding using such function to get the effective status of the connection. Since the function `pgagroal_connection_state_as_string` keeps the already existent statuses, the text output is not changed. However, in the case `Unknwon` is reported, the function places also the numeric constant in the output so that it will be easy to debug edge cases. Close agroal#473
|
Merged. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgagroal-cliwas reporting the wrong status for connections because it was decoding the connection status viapgagroal_server_state_as_stringthat is used to decode the status of a server.This commit renames the already existent function
pgagroal_get_state_stringaspgagroal_connection_state_as_stringfor consistency with the serverone (
pgagroal_server_state_as_string``) and makes the management decoding using such function to get the effective status of the connection. Since the functionpgagroal_connection_state_as_stringkeeps the already existent statuses, the text output is not changed. However, in the caseUnknwon` is reported, the function places also the numeric constant in the output so that it will be easy to debug edge cases.Close #473