Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a toggle project centroids component #30

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Nov 12, 2024

this component allows the features to be toggled with the centroids. The lock icon locks in the choice regardless of the scale.

@steveoh steveoh requested a review from stdavis November 12, 2024 22:40
@steveoh steveoh linked an issue Nov 12, 2024 that may be closed by this pull request
4 tasks
@steveoh steveoh changed the title feat: create a toggle project centroids component feat: add a toggle project centroids component Nov 12, 2024
@steveoh steveoh enabled auto-merge (squash) November 12, 2024 22:41
Copy link

github-actions bot commented Nov 12, 2024

Visit the preview URL for this PR (updated for commit 20d7cf2):
Firebase Preview: https://ut-dts-agrc-wri-dev--feat-2-toggle-between-project-cen-a031czg7.web.app
(expires "2024-11-27T00:03:04.206951226Z" )

Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. However, it appears that the preview is 404ing on some bundles.

.vscode/settings.json Outdated Show resolved Hide resolved
@steveoh
Copy link
Member Author

steveoh commented Nov 12, 2024

it appears that the preview is 404ing on some bundles.

Hmm, the prod website will be hosted on the wri slash so it will work in prod. I'll need to find a solution to allow the previews to continue to function.

@steveoh
Copy link
Member Author

steveoh commented Nov 13, 2024

Ok, the preview should be good to go.

@steveoh steveoh requested a review from stdavis November 13, 2024 00:04
@steveoh steveoh merged commit efd1d7d into main Nov 13, 2024
7 checks passed
@steveoh steveoh deleted the feat/2-toggle-between-project-centroids-and-geometries branch November 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle between project centroids and geometries
2 participants