Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash Screen #65

Closed
stdavis opened this issue Aug 3, 2022 · 2 comments · Fixed by #82, #83, #84, #85 or #86
Closed

Splash Screen #65

stdavis opened this issue Aug 3, 2022 · 2 comments · Fixed by #82, #83, #84, #85 or #86
Assignees
@stdavis
Labels
enhancement New feature or request

Comments

@stdavis
Copy link
Member

stdavis commented Aug 3, 2022

We would also like to add a simple splash screen to the map similar to Web AppBuilder's Splash widget. Ideally, the splash screen would take HTML input that we could create in the config file. It would be nice if there was an option in the config file to enable or disable the splash screen. It might also be nice to have a "Don't Show This Again" checkbox for users to dismiss the splash screen for future sessions. The use case: when we disable commenting on this map, the splash screen would inform users that commenting is no longer permitted on the map. It could also serve the purpose of a simple info panel (issue #43).
@stdavis stdavis added the enhancement New feature or request label Aug 3, 2022
@stdavis stdavis self-assigned this Aug 19, 2022
@stdavis
Copy link
Member Author

stdavis commented Aug 19, 2022

Another thought: As currently implemented, once the user checks the "Don't Show This Again" option, then the splash screen will never be shown to that user again unless they manually clear their browser's localStorage or maybe after a major browser upgrade or something.

We could make it so that this is specific to the version of the application. So each time the app version number changes, the user would have to dismiss it again.

stdavis added a commit that referenced this issue Aug 19, 2022
@stdavis
feat: implement splash screen
24feca9 
If the `splashScreen.content` prop becomes unwieldy, we can move it to a separate config file.

Closes #65
stdavis added a commit that referenced this issue Aug 24, 2022
@stdavis
feat: implement splash screen
de576fa 
If the `splashScreen.content` prop becomes unwieldy, we can move it to a separate config file.

Closes #65
@github-actions github-actions bot mentioned this issue Aug 24, 2022
Closed
This was referenced Sep 2, 2022
Merged
Merged
Merged
Closed
Closed
Merged
This was referenced Sep 2, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
@msilski
Copy link
Contributor

msilski commented Sep 7, 2022

I tested out the splashScreen.enabled property and I'm not sure it is working. I've set it to false, set it to null, and removed the property from the config and the splashScreen stays enabled. Could you take a look at it?

@stdavis stdavis reopened this Sep 7, 2022
stdavis added a commit that referenced this issue Sep 7, 2022
@stdavis
fix: wire up config.splashScreen.enabled config
009718a 
Finishes up #65
@stdavis stdavis closed this as completed Sep 7, 2022
stdavis added a commit that referenced this issue Sep 9, 2022
@stdavis
fix: wire up config.splashScreen.enabled config
454f6bd 
Finishes up #65
@ugrc-release-bot ugrc-release-bot bot mentioned this issue Oct 5, 2022
Closed
@github-actions github-actions bot mentioned this issue Dec 15, 2022
Merged
@github-actions github-actions bot mentioned this issue Dec 16, 2022
Merged
@ugrc-release-bot ugrc-release-bot bot mentioned this issue Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdavis stdavis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@stdavis @msilski