-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate health care facilities #2810
Conversation
✅ Deploy Preview for gis-utah-gov ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Will you link to the porter issue if this is related to a porter issue please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good time in the porter process to remove the page but a couple of things should be done before merging this.
- The associated downloadMetadata.ts record needs to have the utah health care facilities entry removed.
- A redirect should be created in the public/_redirects that redirects people to the new product page.
I feel like the goal posts are always shifting. |
I hear you. I wouldn't mind understanding offline what things you feel like are changing often so we can plant the posts in the same place each time. The downloadMetadata item is referenced in the page, creating a link between them, and therefore need to be created and removed together. If that doesn't happen we end up with orphan entries and no one wants that. We don't want to break the web by removing pages. The current page is indexed in search engines etc and to be nice to folks looking for health facilities, we have the opportunity to correct their destination. It's one line in a file. This will always be the case for data replacements but is not necessary for new pages. I'm hoping that there are maybe 2 or 3 goal posts and we're getting familiar with their location instead of them constantly moving. Again, if that's not the case, i'd like to understand your thoughts offline. |
Redirects Validation Output
|
2462d02
to
3e690eb
Compare
Remove health care facilities in favor of licensed health care facilities