Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate health care facilities #2810

Merged
merged 3 commits into from
Aug 8, 2024
Merged

deprecate health care facilities #2810

merged 3 commits into from
Aug 8, 2024

Conversation

ZachBeck
Copy link
Member

Remove health care facilities in favor of licensed health care facilities

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for gis-utah-gov ready!

Name Link
🔨 Latest commit 2b01329
🔍 Latest deploy log https://app.netlify.com/sites/gis-utah-gov/deploys/66b41ed4325de70008fbdeeb
😎 Deploy Preview https://deploy-preview-2810--gis-utah-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@steveoh
Copy link
Member

steveoh commented Jul 23, 2024

Will you link to the porter issue if this is related to a porter issue please

@ZachBeck
Copy link
Member Author

Porter #256

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good time in the porter process to remove the page but a couple of things should be done before merging this.

  1. The associated downloadMetadata.ts record needs to have the utah health care facilities entry removed.
  2. A redirect should be created in the public/_redirects that redirects people to the new product page.

@ZachBeck
Copy link
Member Author

I feel like the goal posts are always shifting.

@steveoh
Copy link
Member

steveoh commented Jul 23, 2024

I feel like the goal posts are always shifting.

I hear you. I wouldn't mind understanding offline what things you feel like are changing often so we can plant the posts in the same place each time.

The downloadMetadata item is referenced in the page, creating a link between them, and therefore need to be created and removed together. If that doesn't happen we end up with orphan entries and no one wants that.

We don't want to break the web by removing pages. The current page is indexed in search engines etc and to be nice to folks looking for health facilities, we have the opportunity to correct their destination. It's one line in a file. This will always be the case for data replacements but is not necessary for new pages.

I'm hoping that there are maybe 2 or 3 goal posts and we're getting familiar with their location instead of them constantly moving. Again, if that's not the case, i'd like to understand your thoughts offline.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Redirects Validation Output

stdout

All redirects validated successfully

stderr


@steveoh steveoh enabled auto-merge (rebase) August 8, 2024 01:26
@steveoh steveoh merged commit 000fbca into main Aug 8, 2024
7 checks passed
@steveoh steveoh deleted the remove-health-facilities branch August 8, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants