Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dependencies are not present in this repository #1

Open
mkrupczak3 opened this issue Jul 12, 2023 · 0 comments
Open

Some dependencies are not present in this repository #1

mkrupczak3 opened this issue Jul 12, 2023 · 0 comments

Comments

@mkrupczak3
Copy link

Hi,

Some required imports are not present in this repository, nor included as a submodule or linked in the README

Specifically, this file with the following missing imports cause the build to fail:

import org.threeten.bp.YearMonth;
import org.apache.commons.lang.builder.CompareToBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

I obtained ThreeTen backport code from the following link:
https://github.com/ThreeTen/threetenbp

I obtained a specific version of the Apache commons-lang library circa Oct 2017 from this commit:
https://github.com/apache/commons-lang/tree/dd2394323b441e7a22d3c85ce751b619918ee161

I obtained Apache commons-io from here:
https://github.com/apache/commons-io

Obtained Simple Logging Facade for Java from here:
https://github.com/qos-ch/slf4j/tree/a8aa7832b7cb8091bc638d12a4fc1abfaaf44d8e/slf4j-api

...and finally got things building

As it was, this was a significant challenge to find all of these disparate imports and integrate them.

Seeing as they're all items mostly related to logging or datetime handling, is there any way you could remove these dependencies from the library? I doubt most users will need them, and their removal would likely make your library more portable. Parsing DTED files without a library such as this one is a significant challenge

-Matthew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant