-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for yubikey-manager #103
base: master
Are you sure you want to change the base?
Conversation
As discussed in the issue ykman isn't drop-in replacement for yubikey-personalization so this is incompatible change |
My patch is compatible with previous version. You can use it with your old challenge. You should read my patch again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, it's interesting.
As for now I spotted few issues with quoting detected by shellcheck, see instructions how to check it yourself.
Also let's keep using printf %
instead of echo -n
for consistency with rest of the code.
It seems this reintroduces #44 (challenge leaks in process list as argument to ykman otp calculate
command). It needs to be addressed.
It should be doable - we need to pipe challenge as before, for example:
printf %s "$YKFDE_REAL_CHALLENGE" | ykman otp calculate "$YKFDE_CHALLENGE_SLOT"
I added new commit to address those issue. Please test it |
There is problem on hooks, I will look at tomorrow. Python is dificult to add library. |
Yes yubikey-manager has a lot of python deps. Adding them to initramfs would be a challenge. |
We have few options:
|
I tested with pyinstaller successfully, but the initramfs's zise is around 50Mb |
I added new commit, please check it, it works with hooks on my machine. |
Can you please squash the commits that are iterative and update the git log to help review? |
Because yubikey-personalization is not under active development, I add support for yubikey-manager. It works fine on my machine for format, enroll and open. I did not test NFC because I do not have NFC machine. For hooks, I added ykman and od, it should work. README should be modified if this commit is approved.
605e5f3
to
a12f931
Compare
I squashed commit, please review it. |
Because yubikey-personalization is not under active development, I add support for yubikey-manager. It works fine on my machine for format, enroll and open.
I did not test NFC because I do not have NFC machine.
For hooks, I added ykman and od, it should work.
README should be modified if this commit is approved.