-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cosmetic appearance of HTML #2
Comments
I'm sure you can appreciate the irony of a dependency elimination tool itself having unnecessary dependencies, so I would prefer not to import other packages solely for cosmetic reasons. I imagine that someone with much more DOM/CSS knowledge than me could easily spruce up the text, layout, and perhaps some of the JS interactions without deeper changes. |
I totally understand. So just extra CSS to improve the appearance without any additional CSS library/framework dependencies. I did notice that you are using jQuery to spruce up the JS interactions? Would you mind them being replaced by vanilla JS? |
Good point, the client-side code does already have a dynamic dependency on jQuery from a CDN. I suppose adding a similar dependency for CSS would be fine, if the CSS project has a good track record and doesn't have additional dependencies of its own. Do you have a particular one in mind? |
Thanks; these both fit the bill. Take your pick. |
Thanks. Will most probably go ahead with Bootstrap since that’s been around the longest time. |
Would improving the cosmetic appearance of HTML be just adding CSS to the existing HTML file? If my understanding is correct, introducing a complicated build process for generating static assets is not required right? I was considering perhaps making a PR where I just link an external minified CSS of a CSS framework/library (perhaps from a CDN) and using classes present with the CSS framework/library to improve the cosmetic appearance of the HTML.
The text was updated successfully, but these errors were encountered: