Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cosmetic appearance of HTML #2

Open
atreya2011 opened this issue Apr 28, 2021 · 6 comments · May be fixed by #3
Open

Improve cosmetic appearance of HTML #2

atreya2011 opened this issue Apr 28, 2021 · 6 comments · May be fixed by #3

Comments

@atreya2011
Copy link

Would improving the cosmetic appearance of HTML be just adding CSS to the existing HTML file? If my understanding is correct, introducing a complicated build process for generating static assets is not required right? I was considering perhaps making a PR where I just link an external minified CSS of a CSS framework/library (perhaps from a CDN) and using classes present with the CSS framework/library to improve the cosmetic appearance of the HTML.

@adonovan
Copy link
Owner

I'm sure you can appreciate the irony of a dependency elimination tool itself having unnecessary dependencies, so I would prefer not to import other packages solely for cosmetic reasons. I imagine that someone with much more DOM/CSS knowledge than me could easily spruce up the text, layout, and perhaps some of the JS interactions without deeper changes.

@atreya2011
Copy link
Author

I totally understand. So just extra CSS to improve the appearance without any additional CSS library/framework dependencies. I did notice that you are using jQuery to spruce up the JS interactions? Would you mind them being replaced by vanilla JS?

@adonovan
Copy link
Owner

Good point, the client-side code does already have a dynamic dependency on jQuery from a CDN. I suppose adding a similar dependency for CSS would be fine, if the CSS project has a good track record and doesn't have additional dependencies of its own. Do you have a particular one in mind?

@atreya2011
Copy link
Author

I had the following two in mind. Both of them have a good track record and a minified CSS available via a CDN.

  1. Bootstrap
  2. Bulma (CSS classes are a bit more semantic and easier to read personally)

I have used both of them in personal and professional projects.

@adonovan
Copy link
Owner

Thanks; these both fit the bill. Take your pick.

@atreya2011
Copy link
Author

Thanks. Will most probably go ahead with Bootstrap since that’s been around the longest time.

@atreya2011 atreya2011 linked a pull request May 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants