Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recsec test data: visually checking a collection of figures created with various options #49

Open
bch0w opened this issue Oct 20, 2022 · 0 comments

Comments

@bch0w
Copy link
Member

bch0w commented Oct 20, 2022

Currently the RecSec tests just plot code functionality but have no check on if the figures look how we want. Some simple checks are to run record section for one of the example events and make sure the data look okay. This is prone to failure as there are a lot of options and option combinations (and growing by the second). By introducing both data and synthetics, mismatching waveform lengths, time shifts etc., it is very easy to slip into a realm where code is executing but figures do not look right.

We need a set of control data (data and synthetics) and a test suite that generates figures for a variety of parameter options/combinations that we might experience in the real world. We can then use the Matplotlib test kit to check resulting .png files against known test results.

Parameter combinations that are testworthy (add to this as we see fit):

  • Data and synthetic comparisons with a move out and xlimits
  • Data and synthetic comparisons where trace start and end times (and sampling rate) are not the same
@bch0w bch0w changed the title recsec test data: a collection of figures with various options recsec test data: visually checking a collection of figures created with various options Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant