@actions/attest Support multiple subjects #1749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Nauth <Forrin@users.noreply.github.com>
|
@Forrin Thanks for the PR! We actually have some work in progress to support multi-subject attestations but first need to roll-out some changes to our attestation store. I'll revisit this when we have all of the prerequisites deployed but until then we can't merge this as it will result in attestations which are incompatible with the GH attestations API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will add support for handling multiple subjects. It's a fairly minor change that will enable attaching many subjects to a single attestation. This could be useful for a variety of situations, such as using the gitcommit and the artifact as subjects. Overall any predicate that references multiple subjects will need this.