refactor: Use early return pattern

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
actions · Dec 29, 2022 · b1daf0a · b1daf0a
1 parent 377c6da
commit b1daf0a
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/src/cache-utils.ts b/src/cache-utils.ts
@@ -63,21 +63,24 @@ const getPackageManagerVersion = async (
 export const getPackageManagerInfo = async (packageManager: string) => {
   if (packageManager === 'npm') {
     return supportedPackageManagers.npm;
-  } else if (packageManager === 'pnpm') {
+  }
+
+  if (packageManager === 'pnpm') {
     return supportedPackageManagers.pnpm;
-  } else if (packageManager === 'yarn') {
-    const yarnVersion = await getPackageManagerVersion('yarn', '--version');
+  }
 
+  if (packageManager === 'yarn') {
+    const yarnVersion = await getPackageManagerVersion('yarn', '--version');
     core.debug(`Consumed yarn version is ${yarnVersion}`);
 
     if (yarnVersion.startsWith('1.')) {
       return supportedPackageManagers.yarn1;
-    } else {
-      return supportedPackageManagers.yarn2;
     }
-  } else {
-    return null;
+
+    return supportedPackageManagers.yarn2;
   }
+
+  return null;
 };
 
 export const getCacheDirectoryPath = async (