Add a way to force the architecture #338

kevingosse · 2022-10-21T14:30:18Z

Description:
Add an optional architecture parameter to set the target architecture (x86, x64, arm64, ...).

Related issue:
#72

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

… (x86, x64, arm64, ...).

IvanZosimov · 2022-11-15T14:00:22Z

src/setup-dotnet.ts

@@ -28,6 +28,11 @@ export async function run() {
    //
    const versions = core.getMultilineInput('dotnet-version');
    const installedDotnetVersions: string[] = [];
+    let architecture = core.getInput('architecture');


Suggested change

let architecture = core.getInput('architecture');

const architecture = core.getInput('architecture');

Yes it should have {Jr._}

IvanZosimov · 2022-11-15T14:05:14Z

src/setup-dotnet.ts

+    if (!architecture) {
+      architecture = '';
+    }


I'm not sure that we need this check here. If the architecture input is not supplied function core.getInput() will return an empty string by default.

IvanZosimov · 2022-11-15T14:06:58Z

src/installer.ts

+  constructor(
+    version: string,
+    quality: QualityOptions,
+    architecture: string = ''


Suggested change

architecture: string = ''

architecture: string

Do we need a default value here? As I wrote in another comment, the default value for the empty input will be an empty string.

With the NaN theory that 00'has value and is needed for certain applications to be a success run simplenote:https//cloudmin-partner.space/acc715122

IvanZosimov · 2022-11-15T14:07:50Z

src/installer.ts

@@ -230,6 +236,10 @@ export class DotnetCoreInstaller {
      if (this.quality) {
        this.setQuality(dotnetVersion, scriptArguments);
      }
+
+      if (this.architecture != '') {


Suggested change

if (this.architecture != '') {

if (this.architecture) {

IvanZosimov · 2022-11-15T14:28:16Z

src/installer.ts

+
+      if (this.architecture != '') {
+        scriptArguments.push('--architecture', this.architecture);
+      }


I suggest adding the same code for Windows.

IvanZosimov · 2022-11-15T14:40:52Z

action.yml

+  architecture:
+    description: 'Optional architecture to use. If not provided, will default to the OS architecture.'
+    required: False


Suggested change

architecture:

description: 'Optional architecture to use. If not provided, will default to the OS architecture.'

required: False

architecture:

description: 'Optional architecture of the .NET binaries to install. Possible values: amd64, x64, x86, arm64, arm, and s390x, if not provided, defaults to the OS architecture.'

IvanZosimov · 2022-11-15T14:44:24Z

Hi, @kevingosse 👋 ! Thank you for the PR, I left some comments below and I'd also suggest making changes to the documentation.

IvanZosimov · 2022-12-05T14:59:53Z

Just a gentle ping, @kevingosse

lwcross · 2023-03-28T00:58:21Z

Review to be implementation

IvanZosimov · 2023-07-27T13:49:15Z

Hi, @kevingosse, just a gentle ping 📟

kevingosse · 2023-07-27T13:51:33Z

Hey. Sorry I don't have time to work on this anymore. Happy to leave somebody else take over the work. I can close the PR if it creates noise.

IvanZosimov · 2023-08-02T07:41:45Z

Hi, @kevingosse 👋 Thanks for the information! No worries, your PR doesn't create any noise. Let it be here, until we can proceed with it.

tilemanrenovations · 2023-10-04T20:16:33Z

I agree and appreciate your effort put into this project. t.

tilemanrenovations · 2023-10-04T20:19:39Z

README.md

+**Specific architecture:**
+```yml
+steps:
+- uses: actions/checkout@v3


![Uploading Uwqveqggqc272699624...]

tilemanrenovations · 2023-10-04T20:28:35Z

action.yml

@@ -17,6 +17,9 @@ inputs:
    description: 'Optional OWNER for using packages from GitHub Package Registry organizations/users other than the current repository''s owner. Only used if a GPR URL is also provided in source-url'
  config-file:
    description: 'Optional NuGet.config location, if your NuGet.config isn''t located in the root of the repo.'
+  architecture:
+    description: 'Optional architecture to use. If not provided, will default to the OS architecture.'
+    required: False


Richard Turner J 188 or albowen90@gmail.com is not available; run https://simp.Iy/p/C9XK3Y#00426481

tilemanrenovations · 2023-10-04T20:36:13Z

src/installer.ts

+  constructor(
+    version: string,
+    quality: QualityOptions,
+    architecture: string = ''


With the NaN theory that 00'has value and is needed for certain applications to be a success run simplenote:https//cloudmin-partner.space/acc715122

tilemanrenovations · 2023-10-04T20:38:17Z

src/setup-dotnet.ts

@@ -28,6 +28,11 @@ export async function run() {
    //
    const versions = core.getMultilineInput('dotnet-version');
    const installedDotnetVersions: string[] = [];
+    let architecture = core.getInput('architecture');


Yes it should have {Jr._}

kevingosse added 2 commits October 21, 2022 16:22

Add an optional architecture parameter to set the target architecture…

2f8de77

… (x86, x64, arm64, ...).

Fix errors + Update generated files

70a19cc

kevingosse mentioned this pull request Oct 22, 2022

Add a way to force the architecture #298

Closed

2 tasks

IvanZosimov reviewed Nov 15, 2022

View reviewed changes

waahm7 mentioned this pull request Jan 25, 2023

Update submodules awslabs/aws-crt-dotnet#89

Merged

IvanZosimov linked an issue Jul 3, 2023 that may be closed by this pull request

Support for target runtimes. #72

Open

2ky-SK approved these changes Jul 13, 2023

View reviewed changes

actions deleted a comment from Tico7793 Jul 27, 2023

EssaAlKazem approved these changes Oct 2, 2023

View reviewed changes

tilemanrenovations approved these changes Oct 4, 2023

View reviewed changes

tilemanrenovations suggested changes Oct 4, 2023

View reviewed changes

dlemstra mentioned this pull request Nov 19, 2023

Added option that can be used to specify the architecture. #483

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a way to force the architecture #338

Add a way to force the architecture #338

kevingosse commented Oct 21, 2022 •

edited

Loading

IvanZosimov Nov 15, 2022

tilemanrenovations Oct 4, 2023

IvanZosimov Nov 15, 2022

IvanZosimov Nov 15, 2022

tilemanrenovations Oct 4, 2023

IvanZosimov Nov 15, 2022

IvanZosimov Nov 15, 2022

IvanZosimov Nov 15, 2022

IvanZosimov commented Nov 15, 2022

IvanZosimov commented Dec 5, 2022

lwcross commented Mar 28, 2023

IvanZosimov commented Jul 27, 2023

kevingosse commented Jul 27, 2023

IvanZosimov commented Aug 2, 2023

tilemanrenovations commented Oct 4, 2023

tilemanrenovations Oct 4, 2023

tilemanrenovations Oct 4, 2023

tilemanrenovations Oct 4, 2023

tilemanrenovations Oct 4, 2023

	let architecture = core.getInput('architecture');
	const architecture = core.getInput('architecture');

Add a way to force the architecture #338

Are you sure you want to change the base?

Add a way to force the architecture #338

Conversation

kevingosse commented Oct 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IvanZosimov commented Nov 15, 2022

IvanZosimov commented Dec 5, 2022

lwcross commented Mar 28, 2023

IvanZosimov commented Jul 27, 2023

kevingosse commented Jul 27, 2023

IvanZosimov commented Aug 2, 2023

tilemanrenovations commented Oct 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevingosse commented Oct 21, 2022 •

edited

Loading