Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for enqueueAt #970

Closed
itleigns opened this issue Aug 4, 2023 · 2 comments · Fixed by #973
Closed

Error handling for enqueueAt #970

itleigns opened this issue Aug 4, 2023 · 2 comments · Fixed by #973
Labels

Comments

@itleigns
Copy link
Contributor

itleigns commented Aug 4, 2023

enqueueAt does not catch an error if it fails in the ioredis function inside.

This is because the format of the Promise returned by ioredis exec is different from the usual as follows. (reference)

const promise = redis.pipeline().set("foo", "bar").get("foo").exec();
promise.then((result) => {
  // result === [[null, 'OK'], [null, 'bar']]
});
@evantahler
Copy link
Member

Thanks for reporting this! Are you able to submit a pull request (and related test) with the fix?

@itleigns
Copy link
Contributor Author

itleigns commented Aug 7, 2023

I did it!
(edit) #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants