Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unintended interaction between Resize Text mod and Collapsible Comments mod #273

Open
aclist opened this issue Apr 8, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@aclist
Copy link
Owner

aclist commented Apr 8, 2024

If the Resize Text mod is on, toggling the Collapsible Comments mod on/off triggers a timeout and opacity check on the KES modal, because this behavior of the Resize Text mod resides in the global scope and the Collapsible Comments change triggers recursion throughout the page

@aclist aclist added the bug Something isn't working label Apr 8, 2024
@aclist aclist added this to the 4.1.0 milestone Apr 8, 2024
@aclist
Copy link
Owner Author

aclist commented Apr 12, 2024

Provisionally resolved by 02440f3, but Collapsible Comments causes the entire DOM for #comments to mutate, triggering all mods to iterate and apply. Resize Text now explicitly checks if the KES modal is on the Resize Text mod before applying opacity, but some observations about this side effect:

  • Collapsible Comments is slow to set/unset because it's actually iterating over every mod. Any way to add an exception for this (using more granular selectors)?
  • Maybe a mod changing the state of the open KES modal should be undefined behavior. Mods shouldn't be manipulating the KES modal itself. Any alternative solution to showing font size increases here? (E.g. a separate preview modal exclusive to the mod?)

@aclist
Copy link
Owner Author

aclist commented Apr 18, 2024

The opacity issue is resolved by 02440f3, but I still feel there is room for improvement here so that the collapsible comments mod itself does not trigger a mutation that forces recursion through all mods. However, this may be intractable in the current design.

@aclist aclist modified the milestones: 4.1.0, 4.2.0 Apr 23, 2024
@aclist aclist modified the milestones: 4.2.0, 4.3.0 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant