You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the Resize Text mod is on, toggling the Collapsible Comments mod on/off triggers a timeout and opacity check on the KES modal, because this behavior of the Resize Text mod resides in the global scope and the Collapsible Comments change triggers recursion throughout the page
The text was updated successfully, but these errors were encountered:
Provisionally resolved by 02440f3, but Collapsible Comments causes the entire DOM for #comments to mutate, triggering all mods to iterate and apply. Resize Text now explicitly checks if the KES modal is on the Resize Text mod before applying opacity, but some observations about this side effect:
Collapsible Comments is slow to set/unset because it's actually iterating over every mod. Any way to add an exception for this (using more granular selectors)?
Maybe a mod changing the state of the open KES modal should be undefined behavior. Mods shouldn't be manipulating the KES modal itself. Any alternative solution to showing font size increases here? (E.g. a separate preview modal exclusive to the mod?)
The opacity issue is resolved by 02440f3, but I still feel there is room for improvement here so that the collapsible comments mod itself does not trigger a mutation that forces recursion through all mods. However, this may be intractable in the current design.
If the Resize Text mod is on, toggling the Collapsible Comments mod on/off triggers a timeout and opacity check on the KES modal, because this behavior of the Resize Text mod resides in the global scope and the Collapsible Comments change triggers recursion throughout the page
The text was updated successfully, but these errors were encountered: