Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sync ODB shared folders from external organisation #969

Closed
wants to merge 36 commits into from

Conversation

@abraunegg abraunegg added this to the v2.4.4 milestone Jul 2, 2020
@abraunegg abraunegg removed this from the v2.4.4 milestone Jul 21, 2020
@justyn
Copy link

justyn commented Sep 1, 2020

Hi, is this branch ready to be tested?

@abraunegg
Copy link
Owner Author

@justyn

Hi, is this branch ready to be tested?

It is best to keep an eye on the issue itself: #966

Right now, the PR is still waiting on the API to be fixed due to the authentication token's not being honored by the API.

@justyn
Copy link

justyn commented Sep 2, 2020

Hi @abraunegg

Thanks for looking into the this feature.

I'm struggling to follow the linked issues... the one in onedrive-api-docs appears to be closed and the Microsoft employee seemed to imply that the code needed help from stack overflow

Do you think Microsoft is aware that there is an issue with the API, are they tracking it somewhere?

cyberatz
cyberatz previously approved these changes Dec 11, 2020
@abraunegg
Copy link
Owner Author

@cyberatz
By approving this change, have you confirmed / validated that this is working as expected - that is, external shares from your organisation can be accessed?

In all my testing thus far, there is an authentication issue - thus failure. If this is succeeding for you, can you please provide the evidence?

* update pr from master
@cyberatz
Copy link

@cyberatz
By approving this change, have you confirmed / validated that this is working as expected - that is, external shares from your organisation can be accessed?

In all my testing thus far, there is an authentication issue - thus failure. If this is succeeding for you, can you please provide the evidence?

sorry @abraunegg - I think I fat fingered something. I've not been able to get it to work yet. unfortunately I cannot seem to undo the review.

@abraunegg abraunegg modified the milestone: v2.5.x Dec 7, 2022
@abraunegg
Copy link
Owner Author

Closing this PR due to v2.5.x re-write, bug #966 will remain open

@abraunegg
Copy link
Owner Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants