Persistent Notification for Critical Problem like Reauthorization?

[erenoglu]

I'm running onedrive using a systemd user service. Works good.
Today just out of curiosity I wanted to check the logs and did a "systemd --user status onedrive" command and saw this:

ERROR: Microsoft OneDrive API returned an error with the following message:
Error Message: HTTP request returned status code 401 (Unauthorized)
Error Reason: Access token is empty.
Error Timestamp: 2023-09-22T07:27:04
API Request ID: abcd-efgh-..

ERROR: Check your configuration as your refresh_token may be empty or invalid. You may need to issue a --reauth and re-authorise this client.

Then I stopped the service, did a manual launch of onedrive with --reauth and got new token, it continued working. But if I didn't look at the systemd logs, I would never noticed this till it hits on a file.

How can we make sure Onedrive shows a persistent notification or better a dialog box that says it needs re-authentication? Over and over again with certain time periods (ie every 5 10 minutes) even if user cancels it? (user can always stop the daemon to prevent more notifications.

Or a red circle / exclamation tray icon some other way to notify that something is critically wrong?

[abraunegg]

@erenoglu

How can we make sure Onedrive shows a persistent notification or better a dialog box that says it needs re-authentication? Over and over again with certain time periods (ie every 5 10 minutes) even if user cancels it? (user can always stop the daemon to prevent more notifications.

Or a red circle / exclamation tray icon some other way to notify that something is critically wrong?

If you are using the GUI (https://github.com/bpozdena/OneDriveGUI) - that would have to be raised there. Potentially raise a feature request for that sort of notification.

The issue itself manifests from your local filesystem - where the reading|writing of the token get's out-of-sync. I saw this heavily in the development of v2.5.0-alpha-0, it would be worth you testing | trying out v2.5.0-alpha-1 for a comparison for this issue.

[erenoglu]

I am not using the GUI, the client was working good on the command line so I gave a shot to the systemd. But I have the GUI app, I'll use it.
I can try the alpha-1.