-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sticky div to the 'Package details' page that will keep the name of the Package visible when the user scrolls #1263
Comments
We could either make the "purl" row sticky... our we could also add the purl to the blue "package details" bar and make this bar sticky? |
Thanks @pombredanne and good idea. Here are several screenshots of the current prototype. Please treat this as just a working draft intended to prompt comments and ideas. This one combines the sticky div (the top row with |
I spoke too soon about opening a PR -- I'd done the exploratory work in my 1228 branch I think, so I'll either open a new branch for this issue or tackle it in the 1228 branch. @pombredanne Do you have a preference? |
@johnmhoran my preference is for smaller focused PRs as they are easier to merge |
Thanks @pombredanne -- I'll handle the sticky div with a separate branch and a separate PR. |
Reference: #1263 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #1263 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
The title says it all. I already wrote the HTML and CSS code for this earlier today -- for an initial draft, at least -- and will start with that when I tackle this issue.
One question: do we want or need a non-white background? A thick bottom border or a bottom box-shadow will make the div more visible when it rests at the top of the page, but we will also have two more rows below it, newly added in my work on issue #1228, which I had contemplated displaying as a 3-row table -- we might have a design/display conflict to resolve when we reach this point.
The text was updated successfully, but these errors were encountered: