Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Hub, InflatCRC, Circles): tidy up unused variable, docstring, comment #49

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/circles/Circles.sol
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ contract Circles is ERC1155, ICirclesErrors {

// Constants

/**
* @notice Issue one Circle per hour for each human in demurraged units.
* So per second issue 10**18 / 3600 = 277777777777778 attoCircles.
*/
uint256 private constant ISSUANCE_PER_SECOND = uint256(277777777777778);

/**
* @notice Upon claiming, the maximum claim is upto two weeks
* of history. Unclaimed older Circles are unclaimable.
Expand Down
4 changes: 2 additions & 2 deletions src/hub/Hub.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ contract Hub is Circles, TypeDefinitions, IHubErrors {
// Constants

/**
* @dev Welcome bonus for new avatars invited to Circles. Set to 50 Circles.
* @dev Welcome bonus for new avatars invited to Circles. Set to 48 Circles.
*/
uint256 private constant WELCOME_BONUS = 48 * EXA;

/**
* @dev The cost of an invitation for a new avatar, paid in personal Circles burnt, set to 100 Circles.
* @dev The cost of an invitation for a new avatar, paid in personal Circles burnt, set to 96 Circles.
*/
uint256 private constant INVITATION_COST = 2 * WELCOME_BONUS;

Expand Down
2 changes: 1 addition & 1 deletion src/lift/InflationaryCircles.sol
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ contract InflationaryCircles is MasterCopyNonUpgradable, ERC20InflationaryBalanc
}

function name() external view returns (string memory) {
// append suffix for "ERC20 static" to the ERC20 name
// append suffix for "-ERC20s" to the ERC20 name (s for "static")
return string(abi.encodePacked(nameRegistry.name(avatar), "-ERC20s"));
}

Expand Down
Loading