From fcde6871f778a92da64e65005b62dacae53ee5f1 Mon Sep 17 00:00:00 2001 From: Benjamin Bollen Date: Thu, 26 Sep 2024 17:26:18 +0200 Subject: [PATCH] (Hub, InflatCRC, Circles): tidy up unused variable, docstring, comment --- src/circles/Circles.sol | 6 ------ src/hub/Hub.sol | 4 ++-- src/lift/InflationaryCircles.sol | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/circles/Circles.sol b/src/circles/Circles.sol index 45d2c63..9255688 100644 --- a/src/circles/Circles.sol +++ b/src/circles/Circles.sol @@ -28,12 +28,6 @@ contract Circles is ERC1155, ICirclesErrors { // Constants - /** - * @notice Issue one Circle per hour for each human in demurraged units. - * So per second issue 10**18 / 3600 = 277777777777778 attoCircles. - */ - uint256 private constant ISSUANCE_PER_SECOND = uint256(277777777777778); - /** * @notice Upon claiming, the maximum claim is upto two weeks * of history. Unclaimed older Circles are unclaimable. diff --git a/src/hub/Hub.sol b/src/hub/Hub.sol index b99a4a9..8777531 100644 --- a/src/hub/Hub.sol +++ b/src/hub/Hub.sol @@ -25,12 +25,12 @@ contract Hub is Circles, TypeDefinitions, IHubErrors { // Constants /** - * @dev Welcome bonus for new avatars invited to Circles. Set to 50 Circles. + * @dev Welcome bonus for new avatars invited to Circles. Set to 48 Circles. */ uint256 private constant WELCOME_BONUS = 48 * EXA; /** - * @dev The cost of an invitation for a new avatar, paid in personal Circles burnt, set to 100 Circles. + * @dev The cost of an invitation for a new avatar, paid in personal Circles burnt, set to 96 Circles. */ uint256 private constant INVITATION_COST = 2 * WELCOME_BONUS; diff --git a/src/lift/InflationaryCircles.sol b/src/lift/InflationaryCircles.sol index 720a8b7..4787747 100644 --- a/src/lift/InflationaryCircles.sol +++ b/src/lift/InflationaryCircles.sol @@ -86,7 +86,7 @@ contract InflationaryCircles is MasterCopyNonUpgradable, ERC20InflationaryBalanc } function name() external view returns (string memory) { - // append suffix for "ERC20 static" to the ERC20 name + // append suffix for "-ERC20s" to the ERC20 name (s for "static") return string(abi.encodePacked(nameRegistry.name(avatar), "-ERC20s")); }