Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to using nanoid@3 to support its use in CJS module bundle #307

Merged
merged 2 commits into from
May 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@ updates:
schedule:
interval: "daily" # weekdays (Monday to Friday)
labels: [ ] # prevent the default `dependencies` label from being added to pull requests
ignore:
- dependency-name: "nanoid"
update-types: ["version-update:semver-major"] # prevent from upgrading from nanoid@3, see for more info: https://github.com/ably/spaces/pull/307
64 changes: 20 additions & 44 deletions demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"ably": "^1.2.45",
"classnames": "^2.3.2",
"dayjs": "^1.11.9",
"nanoid": "^4.0.2",
"nanoid": "^3.3.7",
"random-words": "^2.0.0",
"react": "^18.2.0",
"react-contenteditable": "^3.3.7",
Expand Down
44 changes: 9 additions & 35 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"vitest": "^0.34.3"
},
"dependencies": {
"nanoid": "^5.0.2"
"nanoid": "^3.3.7"
},
"peerDependencies": {
"ably": "^1.2.46",
Expand Down
Loading