Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRYPTOPP_DISABLE_ASM build broken on Windows and MSys with 8.9.0 #101

Open
abdes opened this issue Oct 2, 2023 · 3 comments
Open

CRYPTOPP_DISABLE_ASM build broken on Windows and MSys with 8.9.0 #101

abdes opened this issue Oct 2, 2023 · 3 comments
Assignees
@abdes

Comments

@abdes
Copy link
Owner

abdes commented Oct 2, 2023

New implementation of checks for intel intrinsics with XGETBV64 and CPUID64 broke the builds on windows and msys.

https://github.com/abdes/cryptopp-cmake/actions/runs/6377366481/job/17305897732#step:11:850
@abdes
Copy link
Owner Author

abdes commented Oct 2, 2023

Issue is linked to the use of CRYPTOPP_DISABLE_ASM when the compiler is MSVC or clang. It seems that GNU compilers have their internal implementation of the undefined symbols with the other two compilers.

@abdes abdes self-assigned this Oct 2, 2023
@abdes
Copy link
Owner Author

abdes commented Oct 2, 2023

see weidai11/cryptopp#1240

@abdes abdes changed the title Build broken on Windows and MSys with 8.9.0 CRYPTOPP_DISABLE_ASM build broken on Windows and MSys with 8.9.0 Oct 2, 2023
@abdes abdes mentioned this issue Oct 2, 2023
Closed
@ghost ghost mentioned this issue Oct 5, 2023
Closed
@abdes
Copy link
Owner Author

abdes commented Oct 15, 2023

Fixed in #103

This issue will be closed one crypto is released with an updated version (@noloader).

@abdes abdes pinned this issue Dec 18, 2023
@abdes abdes mentioned this issue Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdes abdes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abdes